Skip to content

Add Sample App#103

Merged
westeezy merged 1 commit into
mainfrom
05-13-add_playwright_e2e_tests_with_ci_caching_for_the_web_platform
May 14, 2026
Merged

Add Sample App#103
westeezy merged 1 commit into
mainfrom
05-13-add_playwright_e2e_tests_with_ci_caching_for_the_web_platform

Conversation

@westeezy
Copy link
Copy Markdown
Contributor

@westeezy westeezy commented May 14, 2026 •
edited
Loading

What changes are you making?

Adding a basic sample app for the web component. Currently there is no checked in web-component so this is just setup. Once the webcomponent is dropped in it should obey the interface with minimal tweaks.

How to test

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)
Releasing a new Swift version?
  • I have bumped the version in platforms/swift/ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Android version?
  • I have bumped the versionName in platforms/android/lib/build.gradle
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

@westeezy westeezy mentioned this pull request May 14, 2026
Merged
11 tasks
@westeezy Graphite App
Copy link
Copy Markdown
Contributor Author

westeezy commented May 14, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@westeezy westeezy mentioned this pull request May 14, 2026
Closed
11 tasks
@westeezy westeezy force-pushed the 05-13-add_playwright_e2e_tests_with_ci_caching_for_the_web_platform branch from 9d8c583 to 3bcf704 Compare May 14, 2026 00:46
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026 •
edited
Loading

Web — Coverage Report

Lines Statements Branches Functions
Coverage: 0%
 100% (1/1) 100% (1/1)

@markmur
Copy link
Copy Markdown
Contributor

markmur commented May 14, 2026

@westeezy we have a top-level e2e directory which is a bit more suitable for the tests. I'd prefer we keep the test code separate to the app code

toneymathews
toneymathews reviewed May 14, 2026
View reviewed changes
Comment thread platforms/web/sample/index.html Outdated
@toneymathews toneymathews force-pushed the 05-13-add_playwright_e2e_tests_with_ci_caching_for_the_web_platform branch from 3bcf704 to 1ecf2b4 Compare May 14, 2026 18:24
@toneymathews toneymathews mentioned this pull request May 14, 2026
Merged
11 tasks
@westeezy westeezy marked this pull request as ready for review May 14, 2026 18:59
@westeezy westeezy requested a review from a team as a code owner May 14, 2026 18:59
@westeezy Graphite App
Copy link
Copy Markdown
Contributor Author

westeezy commented May 14, 2026

ah okay sorry i didnt see that so ill strip this back. good catch!

@toneymathews toneymathews force-pushed the 05-13-add_playwright_e2e_tests_with_ci_caching_for_the_web_platform branch from 1ecf2b4 to 5467d66 Compare May 14, 2026 19:34
@toneymathews toneymathews mentioned this pull request May 14, 2026
Closed
11 tasks
@westeezy westeezy force-pushed the 05-13-add_playwright_e2e_tests_with_ci_caching_for_the_web_platform branch from 5467d66 to 57e0592 Compare May 14, 2026 20:41
@westeezy westeezy force-pushed the checkout-kit-web branch from b88c084 to 508ad6b Compare May 14, 2026 20:41
@westeezy westeezy changed the title Add Playwright E2E tests with CI caching for the web platform Add Sample App May 14, 2026
@westeezy Graphite App
Copy link
Copy Markdown
Contributor Author

westeezy commented May 14, 2026

@markmur removed e2e and just sample app now

@westeezy westeezy force-pushed the 05-13-add_playwright_e2e_tests_with_ci_caching_for_the_web_platform branch 3 times, most recently from 8134a52 to 73c41fd Compare May 14, 2026 20:56
@westeezy westeezy changed the base branch from checkout-kit-web to graphite-base/103 May 14, 2026 21:08
@kev-mao kev-mao mentioned this pull request May 14, 2026
Merged
11 tasks
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 14, 2026 •
edited
Loading

Merge activity

  • May 14, 9:39 PM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • May 14, 9:39 PM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..

@westeezy westeezy force-pushed the graphite-base/103 branch from 508ad6b to 278e927 Compare May 14, 2026 21:46
@westeezy westeezy force-pushed the 05-13-add_playwright_e2e_tests_with_ci_caching_for_the_web_platform branch from 73c41fd to 7be2cd0 Compare May 14, 2026 21:46
@graphite-app graphite-app Bot changed the base branch from graphite-base/103 to main May 14, 2026 21:48
@westeezy westeezy force-pushed the 05-13-add_playwright_e2e_tests_with_ci_caching_for_the_web_platform branch from 7be2cd0 to 31d7c9b Compare May 14, 2026 21:48
@westeezy westeezy merged commit 0946d24 into main May 14, 2026
17 checks passed
@westeezy westeezy deleted the 05-13-add_playwright_e2e_tests_with_ci_caching_for_the_web_platform branch May 14, 2026 21:51
@markmur markmur added the #gsd:50662 Rebase Checkout Kit on UCP label May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toneymathews toneymathews toneymathews approved these changes

Assignees

No one assigned

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@westeezy @markmur @toneymathews